search

Wilfred / ag.el

An Emacs frontend to The Silver Searcher
http://agel.readthedocs.org/en/latest/
524 stars 61 forks source link

"k" keymap for ag-mode #79

Closed hongxuchen closed 9 years ago

hongxuchen commented 9 years ago

Would you please remove keymap for k in ag-mode map, or replace it with q? I suppose that people using vim and emacs simultaneously will mistakenly press k and quit the buffer.

Wilfred commented 9 years ago

Duplicate of #72. I'd rather we only did that when evil-mode is active, rather than unconditionally. Note that q and k are slightly different, q buries the buffer (the compilation-mode default) whereas k actually kills it.

Working on it now.

hongxuchen commented 9 years ago

Sorry that i didn't find that it was duplicated.

I guess q is better bind to quit-window as *grep*(rgrep, grep) buffer does?

Wilfred commented 9 years ago

q is indeed bound to quit-window :)

hongxuchen commented 9 years ago

so i guess to follow grep's convention, there is no need for ''k"?

Thanks and Regards, Hongxu

On Tue, Dec 16, 2014 at 5:02 AM, Wilfred Hughes notifications@github.com wrote:

q is indeed bound to quit-window :)

— Reply to this email directly or view it on GitHub https://github.com/Wilfred/ag.el/issues/79#issuecomment-67065157.

Wilfred commented 9 years ago

quit-window doesn't kill the buffer, so kill-buffer is bound to k for users who do want to kill the buffer. See #62.

hongxuchen commented 9 years ago

quit-window doc tells that with prefix argument KILL non-nil, it kills the buffer rather than bury it.

Also, I guess that you can suggest keymap for "kill-buffer" in the comments or README.md?

Thanks and Regards, Hongxu

On Tue, Dec 16, 2014 at 5:38 AM, Wilfred Hughes notifications@github.com wrote:

quit-window doesn't kill the buffer, so kill-buffer is bound to k for users who do want to kill the buffer. See #62 https://github.com/Wilfred/ag.el/issues/62.

— Reply to this email directly or view it on GitHub https://github.com/Wilfred/ag.el/issues/79#issuecomment-67070591.