Closed purcell closed 9 years ago
Makes perfect sense. Thank you :)
Thinking about this some more, I'd prefer that ag.el offered some level of discoverable completion (unlike completing-read
, which doesn't give you any hints until you press <TAB>
). However, I understand that helm users would prefer helm completion (I presume that's how you discovered this?).
So, I propose we use helm if available, and fall back to ido otherwise. What do you think?
So, I propose we use helm if available, and fall back to ido otherwise. What do you think?
No, there's really no need for any package author to do that IMO.
The regular completing-read will complete on TAB. Rabid ido
users have ido-ubiquitous-mode
enabled, which overrides completing-read
to do what they want, including in this case. And helm
users use helm-mode
to make completing-read
call helm
. So if we just use completing-read
, everyone will be happy.
Aside: I prefer ido
for most things, but have helm
installed too for some use cases. I'd be upset if ag
decided to start calling helm
for me.
The built-in completing-read can be overridden by ido-ubiquitous-mode and helm-mode, so it seems preferable to not assume that ido should always handle this prompt.