search

Wilfred / deadgrep

fast, friendly searching with ripgrep and Emacs
716 stars 46 forks source link

Make extra arguments customizable #138

Closed gvol closed 1 year ago

gvol commented 1 year ago

This allows users to (easily) solve many of their own problems. For example, I have lots of types in my ~/.ripgreprc that I don't want to repeat in Emacs, so --no-config is very bad for me. This should also solve #24, #110, and probably others that I have missed.

Wilfred commented 1 year ago

Most of these arguments are important for how deadgrep parses the output from rg. How about defining a customisable deadgrep-extra-arguments variable that only includes --no-config by default?

gvol commented 1 year ago

Yeah, that's a better idea. :)

gvol commented 1 year ago

BTW, this has an ordering dependency with #93 (which I would love to get merged as well). Let me know which of them you would like to merge first and I can update the other with the appropriate changes (to tests).

gvol commented 1 year ago

Any thoughts on this and/or #93 @Wilfred?

Wilfred commented 1 year ago

This looks good, merging :)

gvol commented 1 year ago

This looks good, merging :)

Great, thanks!