Fix off by one errors - Githubissues

Wilfred / difftastic

a structural diff that understands syntax 🟥🟩

https://difftastic.wilfred.me.uk/

MIT License

20.59k stars 333 forks source link

Closed RGBCube closed 2 months ago

Wilfred commented 2 months ago

I don't think this is correct. Do you have a failing file example?

RGBCube commented 2 months ago

I don't think this is correct. Do you have a failing file example?

I used to, and it seems I forgot to follow up to this PR and show it 😅

Now it's long gone. I haven't experienced another panic in a while, so maybe it has already been fixed. I'll close this PR

RGBCube commented 2 months ago

I now actually have a lot of test cases where difft panics: difft-panic.tar.gz

Each one of these files panic with Difftastic 0.58.0 (built with rustc 1.78.0), assuming you diff the correct files (.a and .b with the same stem)

@Wilfred this might be of some help