Wilfred / elisp-refs

semantic code search for emacs lisp
117 stars 18 forks source link

Some cleanup and no longer depend on loop #26

Closed tarsius closed 4 years ago

tarsius commented 4 years ago

Two years ago, in #21, I experimented with using magit-section.el in this package. Recently I released that library as separate package, so I picked that experiment up again. If nothing else it might serve as an example for how to use magit-section in a package that isn't Magit.

Anyway, I did some cleanup while working on that and now propose those changes using this this pull request.

I am aware that you are the author of loop but I still think you should avoid depending on an additional package just to make a single function slightly ~less~ more readable.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-4.2%) to 71.072% when pulling 1e96ed2eb0379bbe968d6e20ec580e2aa168e7d6 on tarsiiformes:cleanup into 0e7ea1574717108ddc2eda5e1bc883d44cd28257 on Wilfred:master.

tarsius commented 4 years ago

coveralls got that wrong.

tarsius commented 4 years ago

Friendly ping!

tarsius commented 4 years ago

And another friendly pint :beer:

Wilfred commented 4 years ago

Thanks!

Yeah, loop.el taught me a lot about writing and testing elisp macros. I almost never find myself needing it in practice though, so I agree the code is better here without it.

tarsius commented 4 years ago

You are welcome!