Wilfred / helpful

A better Emacs *help* buffer
1.11k stars 62 forks source link

Improve `Advice` section #265

Open nbfalcon opened 3 years ago

nbfalcon commented 3 years ago

#

nbfalcon commented 3 years ago

Here is how this looks now: 20210313-120043

The buffer in the middle shows the code used to create the function with advice. defadvice! is a doom-emacs advice definition functions, and it is basically defun + advice-add (i.e. using nadvice), so this works with both kinds of advice. A limitation of the current implementation is that defadvice (the old one) advice does not display the actual advice function, but ad-Advice-. IMHO this is better addressed upstream, but I can implement better display if you wish.

nbfalcon commented 3 years ago

For comparison, here is how this looks in master (helpful--skip-advice` doesn't work properly): 20210313-120544