Open nbfalcon opened 3 years ago
Here is how this looks now:
The buffer in the middle shows the code used to create the function with advice. defadvice!
is a doom-emacs advice definition functions, and it is basically defun
+ advice-add
(i.e. using nadvice
), so this works with both kinds of advice. A limitation of the current implementation is that defadvice
(the old one) advice does not display the actual advice function, but ad-Advice-
. IMHO this is better addressed upstream, but I can implement better display if you wish.
For comparison, here is how this looks in master (
helpful--skip-advice` doesn't work properly):
helpful--skip-advice
now works for non:around
advice. This means that the docstring no longer displays any advice.Advice
section no longer just says "This function is advised", but now lists the advice, one per line, with the format<clickable X to remove> :<before/after/...> <advice symbol>
:#