search

Wilfred / helpful

A better Emacs *help* buffer
1.1k stars 62 forks source link

Fix advised native-compiled function being treated as primitives #295

Closed kisaragi-hiu closed 2 years ago

kisaragi-hiu commented 2 years ago

In Emacs 28, subrp is t for a native-compiled function; to check whether a function is a primitive, there is a new function subr-primitive-p.

Previously, unadvised functions have an extra check that does the same thing as subr-primitive-p, but that was not applied to advised functions. This PR applies it to both.

This should fix #277.

Wilfred commented 2 years ago

Thanks :)