Open kisaragi-hiu opened 2 years ago
Been looking forward to functionality of interactive advice toggling for quite a while. To sweet not to merge!
Great! It would be better if it supports hooks as well 😁
@kisaragi-hiu
I tried this patch on Emacs 29, and it failed because advice--where
has been replaced by advice--how
. advice--where
is still around as a deprecated function, but advice--where-alist
is gone. I guess that is the risk of relying on internal APIs.
This lists every new style advice (nadvice.el) of a callable in the Advice section instead of simply saying that it is advised. Further, a button is provided for each advice to remove it.
Another button is provided to remove all advices from the callable. This also removes old style advices.
Mentions of all advices in the docstring (the "This function has :around advice:" line) are removed, regardless of whether they come before the docstring or after (Emacs 28 change), or whether they come from advice.el or nadvice.el.
helpful--advices
: New function that returns new style (nadvice.el) advices of a given symbolhelpful--skip-advice
: Remove docstring mentions of new style adviceshelpful-update
: Only show Advice section if we're describing a callable; revamp Advice sectionThis is similar in spirit to #265. The differences are:
advice--symbol-function
and other nadvice.el utilities instead of the docstringad-Advice-...
, I fall back to the "this {function,macro} is advised" text as removing the old style advice using new style advice utilities seems wrong.