search

Wilfred / helpful

A better Emacs *help* buffer
1.1k stars 62 forks source link

Use help-key-binding as face for keystrokes #307

Closed nbarrientos closed 1 year ago

nbarrientos commented 1 year ago

Emacs 28 introduced a new face for keystrokes (help-key-binding) which is used both in *Help* buffers and tooltips. Thought it might be a good idea if Helpful used it too, it looks nice :smiley:

Before:

image

After:

image

Note the nicely boxed keystrokes in the Key Bindings and Documentation sections.

I could create a new face say helpful-key-binding inheriting from help-key-binding if you want to allow users to customise further.

Thanks for considering this patch.

Wilfred commented 1 year ago

Thanks! Looks good, and it's great having tests :)