search

WilhelmusLab / IceFloeTracker.jl

Julia package for ice floe tracker
https://wilhelmuslab.github.io/IceFloeTracker.jl/
MIT License
1 stars 2 forks source link

Feat add getiftversion #331

Closed cpaniaguam closed 1 year ago

cpaniaguam commented 1 year ago

This is an idea that occurred to me overnight. I think it might work!

cpaniaguam commented 1 year ago

This looks good! I'm not sure why the CI would fail? I tested it and the function works as expected: image

It's a weird error. When the tests are running Pkg.TOML.parsefile("Project.toml") doesn't contain the "version" key. It might be a Julia bug. We could handle the error so CI completes, or just hard-code the version number and remember to update it every time changes are made 😖

cpaniaguam commented 1 year ago

This looks good! I'm not sure why the CI would fail? I tested it and the function works as expected: image

It's a weird error. When the tests are running Pkg.TOML.parsefile("Project.toml") doesn't contain the "version" key. It might be a Julia bug. We could handle the error so CI completes, or just hard-code the version number and remember to update it every time changes are made 😖

I just recalled that there is another Project.toml file in the test folder. I guess I'll add the version number there and see it that fixes it.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.07% :warning:

Comparison is base (d3e2201) 91.84% compared to head (65994ce) 91.78%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #331 +/- ## ========================================== - Coverage 91.84% 91.78% -0.07% ========================================== Files 29 29 Lines 871 876 +5 ========================================== + Hits 800 804 +4 - Misses 71 72 +1 ``` | [Files Changed](https://app.codecov.io/gh/WilhelmusLab/IceFloeTracker.jl/pull/331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WilhelmusLab) | Coverage Δ | | |---|---|---| | [src/IceFloeTracker.jl](https://app.codecov.io/gh/WilhelmusLab/IceFloeTracker.jl/pull/331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WilhelmusLab#diff-c3JjL0ljZUZsb2VUcmFja2VyLmps) | `93.33% <80.00%> (-6.67%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cpaniaguam commented 1 year ago

Seems to have worked!

cpaniaguam commented 1 year ago

@JuliaRegistrator register

JuliaRegistrator commented 1 year ago

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.