search

WilhelmusLab / IceFloeTracker.jl

Julia package for ice floe tracker
https://wilhelmuslab.github.io/IceFloeTracker.jl/
MIT License
1 stars 2 forks source link

feat: hardcode pkg version number #332

Closed cpaniaguam closed 1 year ago

cpaniaguam commented 1 year ago

This approach is working well with IFTPipeline!

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.06% :tada:

Comparison is base (65994ce) 91.78% compared to head (1640a21) 91.84%. Report is 1 commits behind head on main.

:exclamation: Current head 1640a21 differs from pull request most recent head 748628e. Consider uploading reports for the commit 748628e to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #332 +/- ## ========================================== + Coverage 91.78% 91.84% +0.06% ========================================== Files 29 29 Lines 876 871 -5 ========================================== - Hits 804 800 -4 + Misses 72 71 -1 ``` | [Files Changed](https://app.codecov.io/gh/WilhelmusLab/IceFloeTracker.jl/pull/332?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WilhelmusLab) | Coverage Δ | | |---|---|---| | [src/IceFloeTracker.jl](https://app.codecov.io/gh/WilhelmusLab/IceFloeTracker.jl/pull/332?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WilhelmusLab#diff-c3JjL0ljZUZsb2VUcmFja2VyLmps) | `100.00% <ø> (+6.66%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cpaniaguam commented 1 year ago

I was testing with Pkg.project().version instead of VersionNumber(0,2,0). It seems to return the version fine and updating the test worked as well. However, it tries to activate a Julia REPL and IFT when I try to commit the changes.

I'll test this within IFTPipeline. Thanks!

cpaniaguam commented 1 year ago

I was testing with Pkg.project().version instead of VersionNumber(0,2,0). It seems to return the version fine and updating the test worked as well. However, it tries to activate a Julia REPL and IFT when I try to commit the changes.

I'll test this within IFTPipeline. Thanks!

When used within IFTPipeline it returns IFTPipeline's version :/. Going back to testing with hard-coding the version number.

cpaniaguam commented 1 year ago

@tdivoll I think hard coding the version number is probably the way to go.

cpaniaguam commented 1 year ago

@tdivoll I think hard coding the version number is probably the way to go.

@tdivoll Things working well within the container.