WilkinsonK / xapi-oxidized

XNAT web API client
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Remove duplicate code in CRUD protocol impls #37

Open WilkinsonK opened 4 months ago

WilkinsonK commented 4 months ago

There is a serious amount of code already manifesting in oxinat_core::protocols implementations. Not only does this look bad, but is horribly complex.

The root of the issue is in turn when trying to construct URIs for the various possibilities per protocol impl. The proposed solution would be to leverage preexisting implementation of the structs used that allows the user to upstream set path values and pass them along the builder path, then preconstruct the URI and doing additional work if necessary.