search

Wilkolicious / twitchAdSkip

141 stars 11 forks source link

Volume does not reset properly after ad break #4

Closed ToxiClay closed 3 years ago

ToxiClay commented 3 years ago 
twitchAdSkip: Volume modified to: '0.61'.
twitchAdSkip: Found ad node at: [data-test-selector="ad-banner-default-text"]
twitchAdSkip: Finding video node to post-fix volume.
twitchAdSkip: Volume before reset: 0.61
twitchAdSkip: Triggering FFZ reset button...
twitchAdSkip: Fixing volume to original value of '0.61' after interval of '2000' ms
twitchAdSkip: Found ad node at: [data-test-selector="ad-banner-default-text"]
twitchAdSkip: Finding video node to post-fix volume.
twitchAdSkip: Volume before reset: 0.61
twitchAdSkip: Triggering FFZ reset button...
twitchAdSkip: Fixing volume to original value of '0.61' after interval of '2000' ms
twitchAdSkip: Post-fixed volume from reset val of '0.10000000149011612' -> '0.00'

After the reset:

  1. The Twitch stream is quieter than it was before the reset
  2. I no longer see the "Volume modified to" message on adjusting the volume slider.

videoNodeVolCurrent appears to be the source of the issue, though I don't know enough to fix it. The issue is caused somewhere between source lines 106 and 136.