Fixed some bugs and edited reqirements

WillBrennan / ImageStitching

Conducts image stitching upon an input video to generate a panorama in 3D

272 stars 58 forks source link

Fixed some bugs and edited reqirements #11

Closed shubham-shahh closed 3 years ago

shubham-shahh commented 3 years ago

Since SIFT can't be used in the newer version, I added a specific version of OpenCV in requirements.txt.

Thanks for this awesome project

WillBrennan commented 3 years ago

Hi there;

Python 2 and Python 3 are supported but the requirements.txt is wrong. 3.4 is a pretty old version now as well. Video stitching and image matting should be sharing a lot more code than what they're doing at the moment. It should call the same class ect.

I'm going to decline this PR and make a larger refactor to the code for this, but thank-you for your help!

shubham-shahh commented 3 years ago

Hi, I could help you refactoring as well. I edited the requirements.txt as a quick solution along with the video_stitching.py because it consisted of code logic from image_stitching.py and wasn't working with videos