Closed Ant01n3 closed 1 year ago
Thanks for raising the issue! Should be an easy fix :) will take a look this evening
Thanks for raising the issue! Should be an easy fix :) will take a look this evening
We should just need to multiply the radii by the scale here right?: https://github.com/WillPower3309/swayfx/blob/7d5d7a3022eb17835cea7af7290b1a5d2fe4b03a/sway/desktop/fx_renderer.c#L700
Thanks for raising the issue! Should be an easy fix :) will take a look this evening
We should just need to multiply the radii by the scale here right?:
Basically, this is what I'd assume the issue is too. I'd like to keep scaling handled in render.c
though, however if I update the render_box_shadow function to scale the corner_radius, the issue remains. Tricky.
fixed by 3f00052
Running this version for a few hours without problems. Nice blur + nice corners + nice shadows ! Very good work 👏👏 Thank you !
Hello,
First, thank you for this project that adds exactly what is missing in Sway.
I think there may be a bug in the way shadows are rendered when the output scale is not 1 for rounded corners.
For a output with scale 1 the rounded corners of borders and shadows perfectly align. When scale is 1.5 or 2 for example, the rounded corners are scaled for the borders but it seems they are not for the shadows. This can be seen as a little gap between the shadow and the border.
It is not really a bug as swayfx still works perfectly, but I guess this is not the expected behavior.
Version: 0.2-474bfb46 (Mar 20 2023, branch 'master')
Configuration:
Here is an example for an output with scale 1.5: