Closed rafaelsgirao closed 1 year ago
Thanks for raising the issue! I'll ping @ErikReider on this, who implemented saturation and is also taking a look at scratchpad behavior
Close should work which is strange
To clarify, would this occur when sending a window to the scratchpad? We (as in sway upstream as well) don't yet support minimization
Can't reproduce either way. Could you provide your config file?
To clarify, would this occur when sending a window to the scratchpad? We (as in sway upstream as well) don't yet support minimization
I can confirm that windows retain saturation when sending and retrieving them to scratchpad.
Can't reproduce either way. Could you provide your config file? Of course. But I've reproduced this on the default config ( just adding the line
for_window [class="discord"] saturation set 0
at the end ). Sway config used
Adding some more information: Windows that lost their saturation get it back after I issue swaymsg reload
and mess around with said window a little.
Also, checking the debug log I sent above again, I noticed these two snippets:
00:00:03.846 [DEBUG] [sway/tree/view.c:503] Checking criteria [class="discord"]
00:00:03.846 [DEBUG] [sway/tree/view.c:508] for_window '[class="discord"]' matches view 0x1d6d130, cmd: 'saturation set 0'
00:00:03.846 [INFO] [sway/commands.c:272] Handling command 'saturation set 0'
Then, down below (presumably after I've closed and reopened Discord from the tray bar), this snippet:
00:00:06.189 [DEBUG] [sway/tree/view.c:503] Checking criteria [class="discord"]
00:00:06.189 [DEBUG] [sway/tree/view.c:505] Criteria already executed
I think that from swayfx's perspective, the window is still the same (which seems plausible), so it doesn't reapply the lost saturation rate.
Hmmm. Seems to be an issue when closing the window into it's appindicator (which discord does by default)
This also applies to other for_window rules/preferences. One example would be my Steam Friends window rule for_window [class="^Steam$" title="^Friends List$"] floating enable
which only works the first time I open the window. So this is a upstream bug
Ah good to know, thanks for the investigation Erik, @rafaelsgirao try raising an upstream issue please :)
Please read the following before submitting:
Please fill out the following:
Swayfx Version:
sway -v
Debug Log:
sway -d 2> ~/sway.log
from a TTY and upload it to a pastebin, such as gist.github.com.Configuration File:
for_window [class="discord"] saturation set 0
.Description:
nix build github:WillPower3309/swayfx
)for_window [class="discord"] saturation set 0
I also noticed both programs I tested this in (Discord and Ferdium) are both running under XWayland, if that matters - I don't know of any minimizable program that runs on native Wayland.