WillPower3309 / swayfx

SwayFX: Sway, but with eye candy!
MIT License
1.29k stars 48 forks source link

Clipped window with smart edge borders on #135

Closed natsukagami closed 1 year ago

natsukagami commented 1 year ago

Please read the following before submitting:

Please fill out the following:

With hide_edge_borders none and smart: with hide_edge_borders none with hide_edge_borders smart

WillPower3309 commented 1 year ago

Seems like this also results in the shadow rendering as if there were borders.

ErikReider commented 1 year ago

Seems like we're not checking if some of the borders should be hidden or not. https://github.com/WillPower3309/swayfx/blob/50e2422e743c0b337097dd2367f82e0d4b20fabc/sway/desktop/render.c#L659-L665

This becomes more complicated when we only hide ex horizonal borders... How should we handle rounded corners if we only show horizontal borders? How does i3-gaps-rounded handle this? 🤔 image

WillPower3309 commented 1 year ago

Seems like we're not checking if some of the borders should be hidden or not. https://github.com/WillPower3309/swayfx/blob/50e2422e743c0b337097dd2367f82e0d4b20fabc/sway/desktop/render.c#L659-L665

This becomes more complicated when we only hide ex horizonal borders... How should we handle rounded corners if we only show horizontal borders? How does i3-gaps-rounded handle this? 🤔 image

Actually not sure if i3-gaps-rounded has rounded borders, I'll take a peek. This would be easier with the border refactor :/ we should think about what we wanna do here. Perhaps we don't support the option on 0.3 and try to support it with the border rework in 1.0

ErikReider commented 1 year ago

Perhaps we don't support the option on 0.3 and try to support it with the border rework in 1.0

Yeah, the border rework will make it easier to do stuff like this:

image

WillPower3309 commented 1 year ago

Perhaps we don't support the option on 0.3 and try to support it with the border rework in 1.0

Yeah, the border rework will make it easier to do stuff like this:

image

Exactly! Let's push this to 1.0