Closed natsukagami closed 1 year ago
Seems like this also results in the shadow rendering as if there were borders.
Seems like we're not checking if some of the borders should be hidden or not. https://github.com/WillPower3309/swayfx/blob/50e2422e743c0b337097dd2367f82e0d4b20fabc/sway/desktop/render.c#L659-L665
This becomes more complicated when we only hide ex horizonal borders... How should we handle rounded corners if we only show horizontal borders? How does i3-gaps-rounded handle this? 🤔
Seems like we're not checking if some of the borders should be hidden or not. https://github.com/WillPower3309/swayfx/blob/50e2422e743c0b337097dd2367f82e0d4b20fabc/sway/desktop/render.c#L659-L665
This becomes more complicated when we only hide ex horizonal borders... How should we handle rounded corners if we only show horizontal borders? How does i3-gaps-rounded handle this? 🤔
Actually not sure if i3-gaps-rounded has rounded borders, I'll take a peek. This would be easier with the border refactor :/ we should think about what we wanna do here. Perhaps we don't support the option on 0.3 and try to support it with the border rework in 1.0
Perhaps we don't support the option on 0.3 and try to support it with the border rework in 1.0
Yeah, the border rework will make it easier to do stuff like this:
Perhaps we don't support the option on 0.3 and try to support it with the border rework in 1.0
Yeah, the border rework will make it easier to do stuff like this:
Exactly! Let's push this to 1.0
Please read the following before submitting:
Please fill out the following:
Swayfx Version:
sway -v
:sway version 0.2
. Specifically, I'm using latest master commit's (7d5d7a3) nix flake, with nixpkgs overriden to latest nixpkgs-unstable (nixOS/nixpkgs@c9ece0059f42e0ab53ac870104ca4049df41b133) commit (so base sway is 1.8.1).Debug Log: will do in a bit.
Configuration File: minimal config is just the default with
hide_edge_borders smart
.With
hide_edge_borders
none
andsmart
: