Only offset view by border size if not fullscreen

WillPower3309 / swayfx

SwayFX: Sway, but with eye candy!

MIT License

1.29k stars 48 forks source link

Only offset view by border size if not fullscreen #145

Closed ErikReider closed 1 year ago

ErikReider commented 1 year ago

Fixes: #129

~Can't reproduce the exact issue but I could reproduce the border always being accounted for, so hopefully this also fixes that issue (the focus issue in the issue video)~

WillPower3309 commented 1 year ago

Thanks Erik! I'll take a look shortly. Previous PR that impacted this behavior linked here for future Will to reference: https://github.com/WillPower3309/swayfx/pull/94

WillPower3309 commented 1 year ago

~~Q: Prior to the original PR (linked above) we called output_surface_for_each_surface, and didn't worry about borders. Mind quickly explaining why we made that change? Just trying to get up to speed~~

Edit: I don't know how to read previous PR comments allegedly

RitariME commented 1 year ago

Thank you @ErikReider, I can confirm this commit fixed the bug.