Closed WillPower3309 closed 1 year ago
Artifacts visible on bottom right corner of floating chromium window , also visible towards edges of floating terminal
Artifacts also occur when moving a floating window over a transparent floating window (more visible if the windows are different colors).
Seems to just be on the edges of the windows, will investigate further.
Artifacts visible on bottom right corner of floating chromium window IMAGE, also visible towards edges of floating terminal
Artifacts also occur when moving a floating window over a transparent floating window (more visible if the windows are different colors).
Seems to just be on the edges of the windows, will investigate further.
This has to do with how we treated the damage.
First we expanded the damage twice the amount if needed (I'll call it damage
) while also creating and only expanding extended_damage
once, then we render everything as usual with damage
. The trick was to then only render to the wlr framebuffer with the extended_damage
with the render_whole_output
function, essentially clipping the blur edges
Still have artifacting issues despite bringing back expanded_damage, hmm. Will look into it later!
Still have artifacting issues despite bringing back expanded_damage, hmm. Will look into it later!
Should be fixed now :)
Not 100% happy with where this is but I figure we can push for a merge and the iterate in a future PR (don't want to hold off 0.3 any longer)
This PR primarily moves the damage expansion for blur and shadows to the
output_damage_whole_container
function inoutput.c
. This lets us clean up a lot ofrender.c
.