search

WillPower3309 / swayfx

SwayFX: Sway, but with eye candy!
MIT License
1.34k stars 54 forks source link

Fix toplevel borders #171

Closed EvysGarden closed 1 year ago

EvysGarden commented 1 year ago

I've added an additional check in render_view_toplevels(...) for the smart_borders setting to fix the issue with transparent borders on smart_borders on and smart_borders no_gaps.

This should fix some issues mentioned in #135.

It seems you have some plans for reworking the border rendering altogether but as of right now, this is a very simple fix.

Some similar logic is happening in view_autoconfigure(...) so maybe this can be done more elegantly but I don't have a deep enough understanding of the codebase to do this more gracefully (if that's currently possible).

WillPower3309 commented 1 year ago

Thanks for the PR, I'll look at this within the next couple days :)

WillPower3309 commented 1 year ago

going to look deeper into view_autoconfigure

WillPower3309 commented 1 year ago

Sorry for the delay, thanks for the contribution!