WillPower3309 / swayfx

SwayFX: Sway, but with eye candy!
MIT License
1.2k stars 47 forks source link

waybar layer_effects issue with shadows #189

Closed justinesmithies closed 7 months ago

justinesmithies commented 1 year ago

I'm using sway version 0.3.1 and when waybar is running with the following setting layer_effects waybar blur enable; shadows enable; corner_radius 3 as default if I toggle waybar using my this keybind bindsym $mod+x exec killall -SIGUSR1 waybar the bar toggles as expected but when it is gone it leaves a partially transparent waybar shape behind which only disappears once it's toggled back on again.

ErikReider commented 1 year ago

Could you provide a recording/screenshot? :)

justinesmithies commented 1 year ago

2023-06-14_13-06-1686746368 2023-06-14_13-06-1686746384 2023-06-14_13-06-1686746397 2023-06-14_13-06-1686746407 If I disable shadows then it doesn't happen.

rehanzo commented 1 year ago

I assume its because the bar is still there technically, just disabled and transparent? If so, if we had something like #159 but for shadows, that would probably fix it.

ErikReider commented 1 year ago

I wonder why the they are setting the opacity to 0 on the Waybar window instead of just hiding and showing the window? This might be a waybar issue

justinesmithies commented 1 year ago

I wonder why the they are setting the opacity to 0 on the Waybar window instead of just hiding and showing the window? This might be a waybar issue

Could it be a Waybar issue even though when I disable shadows for the waybar layer_effects it works ok ?? Also the same waybar config with the same keybinding to toggle it works on swaywm and hyprland.

ErikReider commented 1 year ago

I wonder why the they are setting the opacity to 0 on the Waybar window instead of just hiding and showing the window? This might be a waybar issue

Could it be a Waybar issue even though when I disable shadows for the waybar layer_effects it works ok ?? Also the same waybar config with the same keybinding to toggle it works on swaywm and hyprland.

They should hide the window instead of just lowering the window behind everything and setting the opacity to 0. The window is still there so Sway can't really tell the difference. They should hide the window properly

ErikReider commented 7 months ago

Closing due to it being a Waybar issue