search

WillPower3309 / swayfx

SwayFX: Sway, but with eye candy!
MIT License
1.2k stars 47 forks source link

Rendering issues on ARM architecture #199

Open AnotherRandomGitHubAccount opened 1 year ago

AnotherRandomGitHubAccount commented 1 year ago

So, I know that this package is marked as not supported by the ARM architecture, but I have used it and it works pretty well except for some rendering issues, so I think it wouldn't take much effort to make it fully supported by ARM. Issues I have: rendering rounded corners sometimes look jagged, especially windows located near the top right of screen, and also there is a diagonal line across the screen in which shadows stop rendering. I understand if adding arm support just isn't worth your time, but if it isn't a hard problem to fix I would really appreciate it. Thanks!

ErikReider commented 1 year ago

It's difficult (for me at least) to debug such graphical bugs when I don't have an arm device to test it on. Have you tried using different drivers? I know some arm devices can use different drivers (vendor and Mesa I think)

AnotherRandomGitHubAccount commented 1 year ago

I'm running on pinebook pro, it has some kind of mali integrated gpu... not sure... but there are no rendering issues with other stuff i think the issue is that this project just wasn't developed with arm in mind... but i think that there are only a few issues that need solving and it shouldn't be hard

RemiSca commented 11 months ago

I'm also facing the diagonal line issue on Apple M1 Pro. The issue is coming from https://github.com/WillPower3309/swayfx/blob/c47aa61c64925c72722dfbfa01cd47643a92c7d9/sway/desktop/fx_renderer/shaders/box_shadow.frag#L60 I've found a technical explanation on stackoverflow: https://stackoverflow.com/questions/11293628/noise-algorithm-fails-in-samsung-galaxy-siii-gles/15846469#15846469 with more links.

I tested by deleting the call to the random function and don't have the issue anymore https://github.com/WillPower3309/swayfx/blob/c47aa61c64925c72722dfbfa01cd47643a92c7d9/sway/desktop/fx_renderer/shaders/box_shadow.frag#L71

AnotherRandomGitHubAccount commented 10 months ago

Oh, that's amazing! I'm not much of a developer (yet) and am still in high school and don't know much about like github ettiquite or how to do things like this, but if it doesn't break anything can someone make a pull request for this?