WillPower3309 / swayfx

SwayFX: Sway, but with eye candy!
MIT License
1.2k stars 47 forks source link

fix: crash when moving to scratchpad tiled window #202

Closed Yaroslav-95 closed 1 year ago

Yaroslav-95 commented 1 year ago

After #171 swayfx started segfaulting on me when moving a tiled window to the scratchpad. After taking a look at the code, I decided it was better if we didn't render a container that was going away to the scratchpad anyway, therefore also avoiding the NULL-dereferencing that was happening inside gaps_to_edge() that led to the segfault.

If you want to reproduce the bug that is currently present in master, you can try just moving a tiled window to the scratchpad. It isn't always triggered, but the possibility that it is triggered increases the more windows you have open in your workspace.

I've tested this PR on my machines, so far so good.