WillPower3309 / swayfx

SwayFX: Sway, but with eye candy!
MIT License
1.2k stars 47 forks source link

feat: add checksum to PKGBUILD #218

Open harogaston opened 10 months ago

harogaston commented 10 months ago

I believe this should work to resolve https://github.com/WillPower3309/swayfx/issues/154 though I don't know how to test it locally. Uses https://github.com/marketplace/actions/publish-aur-package

WillPower3309 commented 10 months ago

Hope you don't mind me requesting your review Erik! You have a lot more packaging experience than I

harogaston commented 10 months ago

Thank you for having a look at it! I repeat that I am not very proficient regarding packaging. Though I could not understand why would there be needed any changes to secrets since this affects only the checksum. And also didn't quite get why PKGBUILD requires any changes, I believe the checksum will be added by updpkgsums.

Sorry if I am completely in the wrong here. Just trying to explain why I did what I did and nothing else but I am not very knowledgeable on this topics so feel free to use it or discard it if it is very far off.

Cheers!

ErikReider commented 3 months ago

We should move this to https://github.com/wlrfx/aur-packages