WillPower3309 / swayfx

SwayFX: Sway, but with eye candy!
MIT License
1.18k stars 48 forks source link

vscodium new window not being rendered #276

Closed Iss-in closed 2 months ago

Iss-in commented 4 months ago

For the last year or so, vscode was crashing on sway/wayland if run in wayland mode, The latest version 1.86 solves that, but it also introduced a new bug, which is making a 2nd window of vscode unable to render.

https://github.com/microsoft/vscode/issues/204597

This was fixed by sway commit https://github.com/swaywm/sway/commit/07b059852673cd9e148c2adfc6bb4f8a0d0ff315 and wlroots commit https://gitlab.freedesktop.org/wlroots/wlroots/-/commit/54e1fefd2e29cb00dff7c02801913d793ceab7d6

can we please add the sway fix here

notpeelz commented 4 months ago

I applied the sway patch you linked against the current release of swayfx but the issue still occurs. The wlroots commit you linked doesn't do anything either.

hashworks (from the vscode issue) is saying he couldn't reproduce the issue when testing with the latest sway/wlroots changes, and not that these specific commits fixed the issue.

Iss-in commented 4 months ago

weird, i will look more into this to single out the commit, latest sway/wlroots indeed fixed the issue. i thought hashworks info was credible

hashworks commented 4 months ago

i thought hashworks info was credible

I never said that it was those specific commits. As notpeelz said, they just were the lastest commits.

Iss-in commented 4 months ago

sorry for the bad info earlier, seems like latest sway release ( 1.9.1 ) has fixed the issue hopefully we can see a rebase soon

WillPower3309 commented 2 months ago

Hey @Iss-in , not sure if you're using swayfx-git, but the rebase is complete. Please let me know if you do and if it fixes the issue :)

Iss-in commented 2 months ago

thanks, will take a look, it seems that scenefx doesnt have an aur package yet, and neither as a dependency in swayfx-git aur package. what version of wlroots is needed to build scenefx ?

ErikReider commented 2 months ago

thanks, will take a look, it seems that scenefx doesnt have an aur package yet, and neither as a dependency in swayfx-git aur package. what version of wlroots is needed to build scenefx ?

It's currently not building, waiting for https://github.com/WillPower3309/swayfx/pull/290. https://github.com/wlrfx/aur-packages/pull/1 is needed for the AUR packages to be uploaded / updated.

You can build it right now though if you build swayfx with scenefx and wlroots 0.17 as subprojects :)

Iss-in commented 2 months ago

thanks, i tried, and sway seems to be crashing when i move mouse or launch some app ( firefox ) http://0x0.st/X-5u.txt

ErikReider commented 2 months ago

The new aur packages are now up and running! :)

Iss-in commented 2 months ago

thanks, seems to be working fine, getting some weird behaviour with borders tho

https://github.com/WillPower3309/swayfx/assets/36916613/fdfa5ba1-c66b-452c-b99e-39679a29185e

# Swayfx settings 
corner_radius 6
shadows enable
shadow_color #000000ff
shadow_blur_radius 6
shadows_on_csd on
# exec_always sway_theme -r
smart_corner_radius disable

blur enable
blur_radius 6
blur_passes 6
blur_xray enable
scratchpad_minimize disable
WillPower3309 commented 2 months ago

thanks, seems to be working fine, getting some weird behaviour with borders tho

https://github.com/WillPower3309/swayfx/assets/36916613/fdfa5ba1-c66b-452c-b99e-39679a29185e

# Swayfx settings 
corner_radius 6
shadows enable
shadow_color #000000ff
shadow_blur_radius 6
shadows_on_csd on
# exec_always sway_theme -r
smart_corner_radius disable

blur enable
blur_radius 6
blur_passes 6
blur_xray enable
scratchpad_minimize disable

Hmm this is alarming! Mind opening a new issue for this? :) I can take a look at it shortly

Iss-in commented 2 months ago

weirdly its also reproducible in upstream release version, happens only when i resize by mouse, but not with keyboard shortcuts

will file issue there

WillPower3309 commented 2 months ago

weirdly its also reproducible in upstream release version, happens only when i resize by mouse, but not with keyboard shortcuts

will file issue there

Thanks! Feel free to link to it here if you do

WillPower3309 commented 2 months ago

Link to upstream issue: https://github.com/swaywm/sway/issues/8125