1.9 merge

[fishman]

render layoer_shell, render, and seatop_move_tiling and fx_renderer are currentlyt he main things that seem to require major changes.

[WillPower3309]

Thanks for the work here! We'd like to use the 1.9 release to transition our fx_renderer to use the fx_renderer we've built in scenefx, which will have feature parity with the fx_renderer bundled in swayfx. As part of that, we will simply just have to import fx_renderer from scenefx and it should be plug and play for that portion of the rebase.

[WillPower3309]

I'm going to make a few additions to this branch to move along some of the WIP parts, I hope you don't mind :)

[WillPower3309]

Should just be render.c that needs fixing now

[WillPower3309]

Relies on the swayfx-compat scenefx branch

[WillPower3309]

right now it is sort of functional but black screens a lot with

00:00:19.617 [wlr] [render/swapchain.c:98] No free output buffer slot

[WillPower3309]

Once the buffer slot issue is fixed, we can start adding back some of the eye candy (lots of TODOs)

[ErikReider]

Seems like there's a lot of missing code from sway 1.9, like the root.c file not compiling without manually copy/pasting the contents from sway 1.9

[WillPower3309]

Event.WINDOW subscribed
Event.MODE subscribed
 err: wayland.c:1470: no compositor00:00:00.486 
[swaynag/swaynag.c:441] failed to register with the wayland display

New fun bug!

[ErikReider]

Not sure if the rebase was applied correctly

[WillPower3309]

All that's left now are adding back the compositor effects in render.c (see the many TODOs), and scenefx

[ErikReider]

Shadow offset and blur is now in :)

[ErikReider]

So this is what's left (feel free to edit this comment with additional features that I've missed):

• [x] Expose fx_renderer as public
• [x] Window corners
• [x] Rounded rects
• [x] Border corners
• [x] Titlebar bottom broder compensation
• [x] scaled + rotated effects

[WillPower3309]

So this is what's left (feel free to edit this comment with additional features that I've missed):

• [ ] Expose fx_renderer as public?
• [ ] Window corners
• [ ] Rounded rects
• [ ] Border corners
• [ ] Titlebar bottom broder compensation

Yup! We should also test everything scaled + rotated.

[WillPower3309]

The bottom border compensation works but also applies when it shouldn't. Will fix tomorrow

[WillPower3309]

scaled shadow damage tracking is broken

[WillPower3309]

While it would be best to hide the fx_renderer implementation details, we will likely need to expose fx_renderer as public before scene is ready

[WillPower3309]

I'm not opposed to backporting scene changes from mainline sway to swayfx early (but only after this is merged)

[WillPower3309]

also need to discuss dimming + saturation. Personally I am starting to think we should deprecate saturation

[ErikReider]

Personally I am starting to think we should deprecate saturation

Agreed! Not really that useful due to direct scanout needing to be disabled

[cvincent]

Was there a feature for using custom shaders? If so, that would supersede custom saturation, wouldn't it?

[WillPower3309]

Was there a feature for using custom shaders? If so, that would supersede custom saturation, wouldn't it?

Yup! We have an open issue for it, but don't have an implementation yet. It would be possible to get saturation with custom shaders, but wouldn't work on Fullscreen windows due to direct scan out

[WillPower3309]

titlebars mostly done, need to properly render the border corners and the tabbed edge container titlebars

[WillPower3309]

ok! All that is left is scaled + rotated effects. Right now there are a couple issues on the scenefx side that I have called out in that PR as well

[WillPower3309]

Shadow scaling mostly fixed, some weird effects between windows evident:

[WillPower3309]

Fine-grained TODO:

• [x] Rotated blur
• [x] Scaled shadows
• [ ] Rotated textures (need to have round proper corners with has_titlebar = true)
• [ ] Shadows not correctly drawn when border size is 0
• [x] Blur cropping on windows w CSD (tracked in https://github.com/wlrfx/scenefx/pull/35)

[WillPower3309]

Found another issue, when moving a floating window the bottom border can be 1 px off in some positions - likely a rounding issue

EDIT: probably just https://github.com/WillPower3309/swayfx/issues/113

[WillPower3309]

We need to have a discussion on if we should keep scaling in the scene side or make it a compositor responsibility

[WillPower3309]

Annoying shadow issue when there are no borders (1px wide black "border" between window and shadow, stencil issue?):

[ErikReider]

Annoying shadow issue when there are no borders (1px wide black "border" between window and shadow, stencil issue?):

Narrowed it down to the stencil smoothstep function acting up. Very strange since we're using the same logic in master 🥴

Edit: Nvm, seems to be present in master as well, so it's at least not a regression :)

[WillPower3309]

Annoying shadow issue when there are no borders (1px wide black "border" between window and shadow, stencil issue?):

Narrowed it down to the stencil smoothstep function acting up. Very strange since we're using the same logic in master 🥴

Edit: Nvm, seems to be present in master as well, so it's at least not a regression :)

Ugh hopefully it'll be fixed once we switch to a matte

[WillPower3309]

With that in mind I think we have feature parity with upstream swayfx now, @ErikReider do you mind giving the render logic another look through? I'll do the same before merging

[OriginCode]

Maybe a little bit off-topic, but will scenefx be tagged soon after or before this PR is merged? It will help a lot for distribution packagers.

[WillPower3309]

Maybe a little bit off-topic, but will scenefx be tagged soon after or before this PR is merged? It will help a lot for distribution packagers.

Yup! As soon as the corresponding scene PR is merged I will tag a release