search

WillPower3309 / swayfx

SwayFX: Sway, but with eye candy!
MIT License
1.17k stars 48 forks source link

Layer shell effects damage tracking on default background #303

Open WillPower3309 opened 2 months ago

WillPower3309 commented 2 months ago

295 fixed a bug where the default gray background has damage tracking issues with blur / shadow enabled:

https://github.com/WillPower3309/swayfx/assets/13266308/45895e80-22ff-47d1-8cd9-f9e9facf7f17

It seems like this issue is still present with layer shell surfaces

ErikReider commented 2 months ago

Is this still an issue btw? Can't seem to reproduce...

ldelossa commented 1 month ago

@ErikReider I'm not 100% sure but I think I'm experiencing this on Gtk4 layer shell surfaces.

https://github.com/WillPower3309/swayfx/assets/5642902/09407e88-f92b-4442-ba15-e905d33f8c27

Here is an example from Way-Shell's OSD.

Its an animated window which animates to 0 margin (bottom of the screen) and then the window is hid. However, the shadow artifacts remain present, until the area is damaged and the frame is re-rendered. I'm not sure if this is exactly the same issue, but looks close (maybe its this issue see in practice?). If its not, just lmk and I'll delete this message.

ldelossa commented 1 month ago

one thing I noticed also is, this only happens when wallpapers are used or the layer-shell window is present ontop of another client window. If I put a plane white or black color background, no artifact is left.