Some menus don't respect the theme applied

[boblaspugna]

Swayfx Version: 0.1-1 from AUR

Description of the issue: Opening some gtk apps, both gtk4 and gtk3, i.e.: Nautilus, Evince, Firefox....., some menus appear with a different color than the theme applied.

This doesn't happen with the default Sway.

I'm using adw-gtk3 theme for gtk3 app with custom colors in:

• gtk3 apps: ~/.config/gtk-3.0/gtk.css;
• gtk4 apps: ~/.config/gtk-4.0/gtk.css;

Here some examples:

Nautilus with Swayfx

Nautilus with Sway

Firefox with Swayfx

[ErikReider]

Are you experiencing this issue with sway 1.7? My initial guess would be that it's an upstream issue that is solved in the sway-git package

[boblaspugna]

With Sway 1:1.7-10, from the normal repo of Arch, everything is fine, as shown in the second screenshot I attached.

[ErikReider]

So it's only the background color right? How did you change the default color to yellow?

[boblaspugna]

This is my ~/.config/gtk-4.0/gtk.css and ~/.config/gtk-3.0/gtk.css

@define-color window_bg_color #eee8d5;
@define-color window_fg_color #586e75;

@define-color accent_color #dbd6c4;
@define-color accent_bg_color #dbd6c4;
@define-color accent_fg_color #073642;

@define-color headerbar_bg_color #f5efde;
@define-color headerbar_fg_color #586e75;
@define-color headerbar_backdrop_color #fdf6e3;

@define-color popover_bg_color #fdf6e3;
@define-color popover_fg_color #073642;

@define-color dialog_bg_color @popover_bg_color;
@define-color dialog_fg_color @popover_fg_color;

@define-color view_bg_color #fdf6e3;
@define-color view_fg_color #073642;

@define-color card_bg_color #eee8d5;
@define-color card_fg_color #073642;

@define-color warning_bg_color #CB4B16;
@define-color warning_fg_color #eee8d5;
@define-color warning_color #CB4B16;
@define-color error_bg_color #DC322F;
@define-color error_fg_color #eee8d5;
@define-color error_color #DC322F;
@define-color success_bg_color #859900;
@define-color success_fg_color #eee8d5;
@define-color success_color #859900;
@define-color destructive_bg_color #D33682;
@define-color destructive_fg_color #eee8d5;
@define-color destructive_color #D33682;

[boblaspugna]

The issue appears also with non-gtk apps, like Telegram:

Telegram with Swayfx

Telegram with Sway

In this case, it seems everything is using a grayscale.

[WillPower3309]

Hmm looks like it's related to our saturation feature. Will investigate

[WillPower3309]

Believe I've found the issue, will fix this evening

[ErikReider]

Hmm looks like it's related to our saturation feature. Will investigate

Oh yeah! Now when you mention it, looks like the first image isn't saturated for some reason. Strange, the default should always be 1.0 😵‍💫

[WillPower3309]

Hmm looks like it's related to our saturation feature. Will investigate

Oh yeah! Now when you mention it, looks like the first image isn't saturated for some reason. Strange, the default should always be 1.0 😵‍💫

My guess is it was due to missing setting saturation in the render_data in the render popups function https://github.com/WillPower3309/swayfx/blob/master/sway/desktop/render.c#L373-L384 so it initialized a value of 0. Easy fix!

[moilong]

Can confirm this because my current build 0.1 showing the same behaviour but previous one that is built before saturation feature added didn"t.

[WillPower3309]

Fixed, will release swayfx 0.1.1 to include the fix. I'll aim to drop the release tomorrow.