search

WillScarlettOhara / BGEE_AI_Denoised_Areas

Mod for Baldur's Gate EE that increases the quality of the game areas
7 stars 3 forks source link

BGEE Denosied Areas for -EET Only!- #3

Open Endarire opened 4 months ago

Endarire commented 4 months ago

Greetings, @WillScarlettOhara!

Last year I updated the BGEE Denoised Areas, but it's for EET only. Not compatible with BGEE. I recommend hosting this as a separate repository on your GitHub. I request credit for EET adaptation.

https://github.com/Endarire/BGEE-Denoised-Backgrounds-for-EET-Only-

Thankee!

Roberciiik commented 4 months ago

Your repository does not contain any files but README. I assume you changed some files on your own, packed them, and released as a package on GitHub with no version control. What is the difference between your version from what is implemented here?

Endarire commented 4 months ago

To clarify, the files are solely in the Release section.

The only notable difference is that my version is for EET only (BGEE side) while Will's is for BGEE only.

Thankee!

Roberciiik commented 4 months ago

According to this #2 there is a new fork with EET support here: https://github.com/haifengkao/EET_BGEE_AI_Denoised_Areas/ It has proper version control, not only the "Release section".

My advice would be to use a proper existing fork, and if you want to make some further modifications you can always fork haifengkao's repository (and not creating dangling one that work as a package storage).

suy commented 4 months ago

I request credit for EET adaptation.

You request credit for renaming a bunch of files, while not giving proper credit to the actual author that did all the effort. You would be the running joke of this community if it weren't for the harm you make.

https://www.gibberlings3.net/forums/topic/37157-endarires-unauthorized-mod-uploads/