search

WillTDA / Discord.js-Akinator

Create an Akinator Command for Your Discord Bot within Seconds of Installation.
https://npmjs.com/package/discord.js-akinator
Apache License 2.0
10 stars 15 forks source link

Moderate issue with got version #41

Closed DiamondCoder02 closed 2 years ago

DiamondCoder02 commented 2 years ago

I have discordjs bot that runs the newest akinator version 4.0.1 and I keep seeing this error. Is there or will there be a fix for this? image

WillTDA commented 2 years ago

Hello 👋 Thanks for bringing this to my attention. I'll be sure to check for any updates to the supporting libraries before publishing the next release (which should be released in a few days). I'll keep this issue open until then. 😃

WillTDA commented 2 years ago

I have updated all of Discord.js Akinator's dependencies to their latest versions. However, even the latest release of @vitalets/google-translate-api, the package Akinator uses to translate extra information, uses vulnerable versions of got it's HTTP request library.

Seeing as @vitalets/google-translate-api has not been updated in 7 months, I will make a fork and update the code myself.

WillTDA commented 2 years ago

After looking through @vitalets/google-translate-api's code, the reason that got is outdated is due to that fact that it is the last version of the package that supported CommonJS.

In the future I may create my own translation library to patch the security vulnerabilities, but the vulnerability mentioned shouldn't really affect your discord bot in anyway.

DiamondCoder02 commented 2 years ago

Yeah, it shouldn't. I'm just annoyed by it. XD Thank you