search

Willena / sqlite-jdbc-crypt

SQLite JDBC Driver with encryption support
Apache License 2.0
172 stars 33 forks source link

Bug fixes and minor improvements #27

Closed Chris-SP365 closed 3 years ago

Chris-SP365 commented 3 years ago

While testing URI, Properties, Pragma I fixed some problems and did minor modifications. Would be great if that could be merged so we don't have to use a forked version.

Willena commented 3 years ago

Thanks for your contribution. I'll look to it very soon. I've recently added the missing tests too. Can you solve the conflict in AllTests.java ?

Chris-SP365 commented 3 years ago

I resolved the conflict. It's really tricky to find out where to fix that issues. Maybe we should report them to the xerial people?

Willena commented 3 years ago

Maybe we should report them to the xerial people?

You can ! Everything that does not belong to the encryption extension could be merged with xerial repo. Just keep in mind that my repo will never be merged inside xerial one, but changes from xerial repo will be merged into my repo.

It's really tricky to find out where to fix that issues.

I'm glad you found and correct them, thank you for that !

What is the version of the binaries you included ? Aside from that I do not like the fact that binaries are stored inside the repository (it not your fault it is like that in xerial too). I'd like to get rid of them for the next version and make them available as an asset from the CI, what do you think about that ?

Chris-SP365 commented 3 years ago

Sorry the comment was a leftover from our default IDEA project settings. I removed it.

The libraries are from October. If the CI can build them automatically then of course its better to not store them in the project. So you can throw them away.