search

William758 / ZetAspects

4 stars 1 forks source link

Incompat with SS2 causing lag spikes #83

Open Hevia opened 1 day ago

Hevia commented 1 day ago

We've long been investigate lag spikes caused by Starstorm 2's Wayfarer TP boss since its release last October. The difficulty issue was the dev team could not reproduce it, but we implemented a bunch of optimizations regardless

With the release of 0.6.8 and reports of lag spikes again that we couldnt reproduce with SS2 alone + profiling (we'd try stress tests with 30+ wayfarers being spawned and no frame drops), we started collecting mod profiles of people reporting lag issues/ We narrowed it down to Aetherium, ZetsAspects, and TinkersSatchel being the co-occurring mods

Phreel later made this comment in the SS2 cord image

Apparently this lag spike also occurs with just SS2 + ZetsAspects or Aetherium + ZetsAspects but I havent had time to confirm myself, and the lag only occurs in specific scenarios (i.e: wayfarer spawns)

Not sure what can be done for compat between mods or what can be refactored, but figured I'd make an issue anyways. Perhaps having "1" as the default option in the config? Or maybe blacklisting follower's buffs from being checked?

Thanks!

Phreelosu commented 1 day ago

this lag spike only happens if all 3 mods are installed, I believe Will is aware as well

SS2 + ZetAspects = no lag spike SS2 + Aetherium = no lag spike SS2 + Aetherium + ZetAspects = lag spike

William758 commented 16 hours ago

I saw some talk on general about the issue and added that config but never got around to testing it. I've gone ahead and prevented bdLampBuff from triggering an inventory update when it expires. I'm not sure how the buffWard for wayfarer is implemented but maybe the buff duration is too short, so the buff keeps expiring before the buffWard would be able to refresh it? Anyway the lag seems to be fixed after testing wayfarer with a swarm of monsters around them.