callback parameter not set in distributed npm module

WilliamDASILVA / nuxt-google-maps-module

Inject Google Maps script

MIT License

22 stars 8 forks source link

callback parameter not set in distributed npm module #1

Closed zsalzbank closed 6 years ago

zsalzbank commented 6 years ago

I am trying to use this module, but the code in the repository does not match what is distributed via npm.

In the repository, the callback when the maps code is loaded is set to initMap.
In the distributed version on npm, the value isn't set (even though the parameter is added to the querystring). However, it is set in the dist directory in the repository.

Can you please update the distributed version on npm to match the code in the repository?

WilliamDASILVA commented 6 years ago

@zsalzbank Yes indeed, I didn't push my changes. Just pushed another hotfix to fix the issue with the deferer + callback & released it on the 1.5.2.

zsalzbank commented 6 years ago

I've updated, but still can't access this.$google from a component (or page). Ideas?

WilliamDASILVA commented 6 years ago

@zsalzbank Yup, had an issue with the inject function when called asynchronously. Fixed it and tested in the mounted event, should work as expected in the version v1.5.3

Tell me if you have any further issues !

zsalzbank commented 6 years ago

Seems to be working - thanks!