search

WilliamLCobb / iNDS

Legacy Repo for iNDS
http://willcobb.me/iNDS.html
236 stars 60 forks source link

Patch mic.mm to fix crash on iOS10 beta 3. #179

Closed jchenevey closed 8 years ago

jchenevey commented 8 years ago

This merge fixes an issue wherein the microphone being accessed was causing a privacy violation crash on iOS 10 beta 3.

quentinlesceller commented 8 years ago

Thank you so much. Working great now.

WilliamLCobb commented 8 years ago

Thank you for this!

jchenevey commented 8 years ago

No problem! Cheers to my first merged pull request on GitHub! :)

Voussoiir commented 8 years ago

@WilliamLCobb closing lid function has been already added? How is it work?

aw8 commented 8 years ago

@WilliamLCobb @jchenevey This patch allows games to run on iOS 10 beta 3, but microphone support doesn't seem to work anymore. (Also, no dialogue appears asking for permission to use the microphone.)

It seems like the problem might be similar to the one solved here: https://forums.developer.apple.com/thread/51985

When I add a microphone usage description to the plist entry and remove the changes made in this commit, microphone support seems to work on iOS 10b3 (as far as I can tell). However, game audio seems to cut out after a few seconds if the microphone is enabled. (not sure if this is a separate issue?)