Also fixing bug where iCade controllers were not working (commented code in startEmulatorLoop) and fixing a bug where the Start and Select buttons were not working correctly.
This PR looks bigger than it is, I mostly moved stuff around and tried to make the logic for controllers as generic as possible.
The important part regarding iCade is that I've replaced the existing logic for mapping button presses on the iCade to button presses in the emulator.
Some buttons (ABXY, Start, Select and LR) might have changed on the original iCade controller, because this is now prepared to work with the 8Bitdo NES30 Pro controller, but this shouldn't be a big deal.
I left the mapping part as generic as possible, so my plan is to potentially add a new section on the settings page so people could change their iCade mappings (8Bitdo NES30 Pro, Original iCade, etc...)
Also fixing bug where iCade controllers were not working (commented code in
startEmulatorLoop) and fixing a bug where the Start and Select buttons were not working correctly.This PR looks bigger than it is, I mostly moved stuff around and tried to make the logic for controllers as generic as possible.
The important part regarding iCade is that I've replaced the existing logic for mapping button presses on the iCade to button presses in the emulator. Some buttons (ABXY, Start, Select and LR) might have changed on the original iCade controller, because this is now prepared to work with the 8Bitdo NES30 Pro controller, but this shouldn't be a big deal.
I left the mapping part as generic as possible, so my plan is to potentially add a new section on the settings page so people could change their iCade mappings (8Bitdo NES30 Pro, Original iCade, etc...)