WilliamRobertMontgomery / asp-dot-net-training-project

Automatically exported from code.google.com/p/asp-dot-net-training-project
0 stars 0 forks source link

Code review for Lab1.Library #174

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
Code review for Lab1.Library

Task (workshop, lab or web project): Lab1.Library
URL: svn/trunk/aleksandr-grechko/Lab1.Library

Original issue reported on code.google.com by aleksand...@gmail.com on 24 Apr 2012 at 4:52

GoogleCodeExporter commented 8 years ago
I've reviewed your code. See my comments in your source code. Please, fix them.

P.S. To view all code review comments you need follow instructions described in 
http://asp-dot-net-training-project.googlecode.com/files/CodeReview.Tutorial.doc
x (point 2)

Original comment by str...@gmail.com on 29 Apr 2012 at 4:51

GoogleCodeExporter commented 8 years ago
Fixed.

Original comment by aleksand...@gmail.com on 30 Apr 2012 at 4:22

GoogleCodeExporter commented 8 years ago
Your fix is good but you should add resource file using following sequence of 
steps:
Add New Item -> Visual C# Items -> General -> Resources File. In this case you 
don't need use explicit string constant to indicate a resource.

Please, fix it.

Original comment by str...@gmail.com on 1 May 2012 at 8:54

GoogleCodeExporter commented 8 years ago
Fixed work with resources.

Original comment by aleksand...@gmail.com on 9 May 2012 at 9:45