WilliamSchack / Spotify-Downloader

A program that downloads songs from spotify
GNU General Public License v3.0
57 stars 3 forks source link

Please make it possible to store it as lossless (original) instead of .mp3 #23

Open haksal732 opened 1 week ago

haksal732 commented 1 week ago

Please make it possible to store it as lossless (original) instead of .mp3

Saving as the original without re-encoding is good for sound quality.

WilliamSchack commented 1 week ago

I am currently working on implementing different codecs but the way that I am downloading the songs it will not be lossless, it originally is an m4a file but I am adding an option to convert it to a wav file although it will not be truly lossless

WilliamSchack commented 1 week ago

Also this is already covered in #6 so keep an eye on that issue for updates :)

haksal732 commented 1 week ago

Thank you :) I have two questions.

As far as I know, Spotify is using the AAC codec, can't I download it as it is? And is 320kbit/s not downloadable?

WilliamSchack commented 1 week ago

So how this downloads the songs is it searches for them on youtube, then downloads it from their so its not directly from spotify. The downside to this is that the quality is lower than on spotify, being about ~128kb/s as an m4a file at the maximum quality so nothing I can really do their without completely changing where I download from. This translates to roughly 256kb/s on an mp3 file and thats why its the max in the program

About the codec, m4a is just a container for aac so it is just really aac but I plan to keep them as separate options anyway when I release support for multiple codecs

WilliamSchack commented 1 week ago

I honestly have no clue why I originally chose mp3 files as well instead of just keeping it at m4a but it was a decision made about 2 years ago when I originally started development and I dont remember my thought process back then

Just glad that I am finally getting around to changing it