Feature request: configurable or parameterized time waiting on socket

WilliamSicongLi / javapns

Automatically exported from code.google.com/p/javapns

0 stars 0 forks source link

Feature request: configurable or parameterized time waiting on socket #224

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago

Last I saw, javapns waited on a failure notice returned on the socket for 5 
seconds. It'd be nice to be tune this.

Original issue reported on code.google.com by ohech...@gmail.com on 11 Nov 2014 at 6:33

GoogleCodeExporter commented 8 years ago

This is pre-tuned based on past experiences with Apple's servers.  Modifying 
this may result in missed responses.

Original comment by sype...@gmail.com on 12 Nov 2014 at 7:10

GoogleCodeExporter commented 8 years ago

Fair enough, and I appreciate it as a probably a sane and generally optimal 
default but that doesn't one should NEVER modify it.

Original comment by ohech...@gmail.com on 12 Nov 2014 at 7:13

GoogleCodeExporter commented 8 years ago

What would be the reason(s) to change this?  I'm asking in order to prioritize 
the request properly.

Original comment by sype...@gmail.com on 13 Nov 2014 at 5:38

GoogleCodeExporter commented 8 years ago

5 seconds is a long time to sit on a socket and I might accept some possibility 
of lost responses. Also, given that Apple's servers change over time, 5 seconds 
may be excessive (my experience with failures has been such that I believe it's 
a bit conservative).

Original comment by ohech...@gmail.com on 14 Nov 2014 at 10:24