WilliamVenner / steamlocate-rs

🎮 Rust Crate for locating Steam game installation directories (and Steam itself!)
MIT License
38 stars 15 forks source link

[Question] why does this depend on two separate vdf parsers? #28

Closed Narcha closed 1 year ago

Narcha commented 1 year ago

What the title says. What justifies the use of both steamy-vdf and keyvalues-parser/keyvalues-serde?

CosmicHorrorDev commented 1 year ago

Apologies for the late reply. Must have missed the initial notification

Originally this crate used steamy-vdf; however, there have been some issues where it failed to parse some valid files (e.g. https://github.com/meh/steamy/issues/1). For this reason part, but not all, of the parsing was moved over to keyvalues-parser

It will be moved to only use keyvalues-parser/keyvalues-serde for the v2 release, but that also involves more-or-less a total rewrite of this crate, so that's still been in progress since I'm very short on time these days. If you don't want to pull in both parsers then you can just use the 2.0.0-alpha.0 release on crates.io which only uses keyvalues-parser/keyvalues-serde

Narcha commented 1 year ago

I see. Thanks!