Base / Make compatible with sumneko.lua

[nodgear]

sumneko.lua Is currently the best lua language server for VSCode and has been forked to be used as roblox/other lua based game scripting. Based on that information, i think it is possible to use it as base for the next vesion of the extension, or, at least make it compatible.

Current incompatibility issues with any lua server:

• Having both extensions enabled will prevent the server from acting, since the extension changes lua extension to use glua language dict.
• Changing glua to lua on all references inside the extension makes the server break and stop while checking files on workspace, causing it to only get references from the current open files and considering any table inside a namespace as a global.

Standalone issues:

• Changes the syntax coloring

[filipovskis]

+1

[luca1197]

I would also really appreciate compatibility with sumneko since apart from the other great features it adds, the syntax highlighting of glua-enhanced doesn't really seem appealing to me with my color theme compared to the one sumneko adds.

For example this screenshot shows glua-enhanced syntax highlighting: https://i.imgur.com/gxpaIXC.png and this one shows sumneko highlighting: https://i.imgur.com/dayNiT8.png

You can see that custom functions aren't highlighted at all (e.g. s:Blur() and s:DrawFull(...)) which makes the code not that nice to read. Maybe it is an issue on my end, if this is the case I would also appreciate a solution for this, but this is currently the only reason I am not using glua-enhanced, because besides that, the extension looks really promising.

[WilliamVenner]

@luca1197 Added

[livkx]

@WilliamVenner Thanks for adding that nice highlighting. As part of the changes you added, are references/definitions supposed to work? Or am I misunderstanding? If I right click on a function which I defined then choose jump to definition it finds nothing.

[WilliamVenner]

@WilliamVenner Thanks for adding that nice highlighting. As part of the changes you added, are references/definitions supposed to work? Or am I misunderstanding? If I right click on a function which I defined then choose jump to definition it finds nothing.

This is not a full language server, I cannot analyze code in extreme detail. Some stuff is actually impossible to fully infer, such as the types of variables. It's not going to work all of the time.

I did not change anything to do with references/definitions.