search

WillianFuks / tfcausalimpact

Python Causal Impact Implementation Based on Google's R Package. Built using TensorFlow Probability.
Apache License 2.0
600 stars 72 forks source link

Getting an error #29

Closed diogoalvesderesende closed 2 years ago

diogoalvesderesende commented 2 years ago

Hi!

I am getting the following error. The error also occurs in previous scripts that worked before.

AttributeError: module 'tensorflow_probability.python.sts' has no attribute 'regularize_series'

You can replicate it in the following link: https://colab.research.google.com/drive/1YZtHDh01NIdU6DrCmGQT6abRF5Nzw5fL?usp=sharing

Let me know if there is something I can clarify.

Thanks, Diogo

WillianFuks commented 2 years ago

Hi @diogoalvesderesende ,

Thanks for opening this issue. As it seems you upgraded tensorflow probability which solves this issue but then another one arose ("index not available").

I'm investigating what happened, hope to get back to you soon.

WillianFuks commented 2 years ago

Hi @diogoalvesderesende ,

Sorry for the delay, I just released a new code to fix this bug. It was caused due changes in the TFP API and your data ended up falling in a scenario that was not tested.

Could you please confirm everything is working now? In the Colab you mentioned I installed the newest tfcausalimpact version 0.0.8rc1 and it seems to be fine now.

Let me know how it goes and I'll release it officially then.

Thanks,

Will

diogoalvesderesende commented 2 years ago

Hey!

Yeah, thanks a lot, now it works great. The one thing I get is 2 deprecation warnings. Are they intended, or do you know whether they make a difference?

WARNING:tensorflow:From /usr/local/lib/python3.7/dist-packages/tensorflow/python/ops/linalg/linear_operator_block_diag.py:238: LinearOperator.graph_parents (from tensorflow.python.ops.linalg.linear_operator) is deprecated and will be removed in a future version. Instructions for updating: Do not call graph_parents. WARNING:tensorflow:From /usr/local/lib/python3.7/dist-packages/tensorflow_probability/python/distributions/distribution.py:346: MultivariateNormalFullCovariance.init (from tensorflow_probability.python.distributions.mvn_full_covariance) is deprecated and will be removed after 2019-12-01. Instructions for updating: MultivariateNormalFullCovariance is deprecated, use MultivariateNormalTriL(loc=loc, scale_tril=tf.linalg.cholesky(covariance_matrix)) instead.

Thanks and best, Diogo

On Thu, 30 Sept 2021 at 23:40, willfuks @.***> wrote:

Hi @diogoalvesderesende https://github.com/diogoalvesderesende ,

Sorry for the delay, I just released a new code to fix this bug. It was caused due changes in the TFP API and your data ended up falling in a scenario that was not tested.

Could you please confirm everything is working now? In the Colab you mentioned I installed the newest tfcausalimpact version 0.0.8rc1 and it seems to be fine now.

Let me know how it goes and I'll release it officially then.

Thanks,

Will

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/WillianFuks/tfcausalimpact/issues/29#issuecomment-931724801, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMTO75HJ5SAF3CIXGEDVJBTUETKLPANCNFSM5E4Y5U6Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

WillianFuks commented 2 years ago

Good to know :). If you find any issues please let me know.

As for the warnings, they are internal to tensorflow probability, unfortunately we didn't find a way to turn them off yet (it's totally fine to ignore them though).

Best,

Will