search

WillianFuks / tfcausalimpact

Python Causal Impact Implementation Based on Google's R Package. Built using TensorFlow Probability.
Apache License 2.0
600 stars 72 forks source link

Fix python version constraint #33

Closed glentakahashi closed 2 years ago

glentakahashi commented 2 years ago

<3.10.* is not a valid PEP440 version specifier

This version constraint breaks installation via poetry and other package management tools

WillianFuks commented 2 years ago

Hi @glentakahashi ,

Thanks for the PR! Before merging I'll try testing the build flow using poetry as you suggested to see what's going on (you mentioned other packaging systems, you mean conda?)

That was a surprise in a way, thought the description was in accordance with PEP already (you can see in the sub-section 'compatible-release' where they use some samples with the same identifier).

Hope to merge it soon.

Best,

Will

glentakahashi commented 2 years ago

Actually idk why i said "other tools" i only tested with poetry haha. And I think .* is only a valid identifier when used with ==, not mix+matched with >= or <=

WillianFuks commented 2 years ago

Fix has already been published. Please let me know if you find any issues.

Best,

Will

glentakahashi commented 2 years ago

Works!! Thank you for the amazingly fast turnaround!