Willy-JL / F95Checker

GNU General Public License v3.0
101 stars 16 forks source link

Fixed scrollbar in game info popup #127

Closed r37r05p3C7 closed 4 months ago

r37r05p3C7 commented 4 months ago

https://github.com/Willy-JL/F95Checker/issues/119#issuecomment-1937855558

Willy-JL commented 4 months ago

why i didnt do that originally is that then constraint is basically useless as its not used anywhere. the idea with it is to leave atleast 5% of space from popup to window borders at all times, so popups dont filly the whole window. but imgui goes wrong with calculations somewhere and shows a scrollbar. this fixes the scrollbar yes, but looks worse imo with the popup touching the window borders up and below. also, i thought the issue was restricted to popups that has nested scrolling areas, but seems like this is not the case, as we see here... not sure what to do then

r37r05p3C7 commented 4 months ago

this fixes the scrollbar yes, but looks worse imo with the popup touching the window borders up and below

i agree, it's a bad trade-off