search

Willy-JL / F95Checker

GNU General Public License v3.0
112 stars 17 forks source link

Fix windows registry key needed for startup #156

Open oneshoekid opened 5 months ago

oneshoekid commented 5 months ago

I'm not sure if it used to work as-is, or maybe still does for some, but at least for me (on version 10.0.22631 Build 22631) I needed to make 2 changes to get F95Checker to run on start up:

  1. move from using a (Default) key in a subfolder of Run (i.e. Run\F95Checker) to a key named F95Checker directly in the Run directory.
  2. surround the path to F95Checker with double quotes instead of single quotes.

Either of these changes on their own didn't work for me.

Willy-JL commented 4 months ago

indeed, i can atleast confirm that it shows up and disappears from task manager's startup tab, which the current implementation does not. very weird, i couldve sworn it worked. ill check if it starts when i reboot.

however those quotation marks concern me 🤔 start_cmd is quoted with shlex, to ensure proper parsing of following arguments. if indeed " is necessary instead of ', replacing it like that will cause issues when run with python (would become "python.exe' 'main.py" with unmatched quotation marks)

oneshoekid commented 4 months ago

Haven't tested it as much, but I think it should also work without any quotes at all if that's preferable.