Willy-JL / F95Checker

GNU General Public License v3.0
112 stars 17 forks source link

Added partial finder for game folder search #163

Open MayhemSixx opened 3 months ago

MayhemSixx commented 3 months ago

Small addition to the game folder finder, to allow the tool to find folders with longer names than just the game title. For example if folder names contain the version number or installed mods.

I placed the check after the first folder search and before the fuzzy search, although I guess it could be combined with the latter.

Apologies in advance if this is written crudely or inefficiently, I'm no programmer and learned the syntax as I wrote the code with about ten Python tutorials open on the side. So don't hesitate to modify anything if needed.

Willy-JL commented 3 months ago

I can see the use in this. Doesn't the fuzzy finder already cover this usecase however?

MayhemSixx commented 3 months ago

Only rarely, due to the way the SequenceMatcher.ratio function works and the fuzzy finder requiring a 0.85 ratio to consider it a match, which is quite high. As an example, the ratio between the strings "Covenant of Morn" and "Covenant of Morn v0.3.3" is 0.82. And obviously it gets even lower if you have stuff like "+Joker mod" in your folder names, so I feel lowering the threshold would either not always be enough or bring the risk of false positives.

FaceCrap commented 1 month ago

What about the other way around?

Example: I have a folder called Neon Nights, within contained there's a Neon Nights1 (the first) and a Neon Nights2 folder (the sequel) Since the first game's name is Neon Nights the picker nicely opens up in the Neon Nights parent folder, so only need to pick the Neon Nights1 folder to select the exe. Howwever, the second one is called Neon Nights 2, and this time the picker opens in my preset base folder, so I have to navigate down into the subfolder struct to get to the exe.