Willy-JL / F95Checker

GNU General Public License v3.0
101 stars 16 forks source link

Tick the "Installed" flag when seleting EXE #33

Closed essaion closed 1 year ago

essaion commented 1 year ago

Hello there,

It's all in the title, again. ;)

Cheers. I'm done for the moment, FWIW. ^^

Willy-JL commented 1 year ago

makes sense

essaion commented 1 year ago

At lastt, one ticket that is not a total screw-up! Yay! \o/

ipaqi commented 1 year ago

Actually disagree, because of the relationship between the Installed flag and the installeds vs available version info. Currently marking the installed flag causes the "installed version" info to be updated to the latest available.

So if you want to get this done at some point, a new state needs to be available for the "installed" flag, of "old version installed". Maybe like a greyed out Checkmark.

Willy-JL commented 1 year ago

Thats true, ive actually found myself in this situation recently, so yeah not gonna do this

essaion commented 1 year ago

Hey, is there any problem with my eyes or did you actually implement a new “installed” state, as @ipaqi suggested? If so, well, back to the feature request, I suppose…? ^_^' (I understand that this assumes that the user is selecting the latest version of the .EXE file, which should be the case more often than not)

Willy-JL commented 1 year ago

Still not really keen on adding this... like yeah now there is a clearer difference between installed outdated and installed latest, but then, say it is unchecked and the user selects an exe... should it be marked as latest? no, thats an assumption... mark as outdated installed? well, also an assumption, and would also require the user to type in the exact version... and if instead the installed checkbox is half set, then selecting an exe should do what? mark as installed latest? again, an assumption that could easily not be true... now that there can also be multiple executables per game and that the checkbox has 3 states, i dont want to confuse the users further with more debatable behavior and assumptions