search

Willy-JL / F95Checker

GNU General Public License v3.0
113 stars 17 forks source link

Change data folder path #6

Closed k0ng1 closed 2 years ago

k0ng1 commented 2 years ago

Option to choose where to store data. that is not in roaming

sorry for my english

Willy-JL commented 2 years ago

I think this option would lead to way too much confusion and weird edge cases... what you should do instead is make a symbolic link: move the config and replace the one in roaming with a symbolic link to the actual file somewhere else on the disk. I might add an example on how to do this for the next update.

CuddleBear92 commented 1 year ago

Can't this be portable though? i can see how people playing with their paths can cause bugs, issues and user error. But a portable path is pretty neat and tidy in general. also easier to just host it on an external drive for those that does that.

Willy-JL commented 1 year ago

It was portable originally, but that caused severe issues with updating. If it were a single executable file, then maybe, but with Python freezing it’s not really acceptable and updating requires swapping hundreds to thousands of files, so ignoring data files could get tricky, fast.

i can see how people playing with their paths can cause bugs, issues and user error.

Having it look in multiple places actually causes more confusion. A regular user won’t care about this feature. An advanced user who would care about this feature is advanced enough to make a symlink. Having this feature instead can cause issues when “where did my games go?!?” if it starts using a portable config instead of a centralized one. The database is small, so no real necessity to move that, images can start occupying a lot of space, and I’m planning to add a way to disable images, or again, use a symlink if space on system drive is an issue