Willy-JL / F95Checker

GNU General Public License v3.0
101 stars 16 forks source link

Titles and Status broken #69

Closed ipaqi closed 1 year ago

ipaqi commented 1 year ago

Something must have changed in f95zone, because the titles you're generating now include the prefixes in the title text

image

Also, Completed status gets reset to Normal, probably the same for OnHold, etc.

Might be a good time to split up the update dialog between version updates and other info updates. I just got 100 updates and none of them were for a new version.

ipaqi commented 1 year ago

Fixed it on my own machine. fix is in parser.py:

line 53: image

line 170: image

This change on f95z's side pretty much breaks usablilty for the update dialog.

I recommend you commit these changes and get out a release version as a hotfix instead of waiting for more features to complete

yohudood commented 1 year ago

i have the same problem but i use the windows exe and have no parser.py

baloneysammich commented 1 year ago

Respect for providing a fix, but screenshots of text... I threw up in my mouth a little bit when I saw that. XD

ipaqi commented 1 year ago

Respect for providing a fix, but screenshots of text... I threw up in my mouth a little bit when I saw that. XD

On the one hand, fair.

On the other hand, there is no actual better way to show the change since Willy doesn't allow people to make pull requests

Willy-JL commented 1 year ago

On the other hand, there is no actual better way to show the change since Willy doesn't allow people to make pull requests

??????????

ipaqi commented 1 year ago

On the other hand, there is no actual better way to show the change since Willy doesn't allow people to make pull requests

??????????

I tried to make a pull request from Visual Studio Code to make this easier and it told me I didn't have permission or whatever.

I assumed that's how the repo is set up (which I believe is the default in GitHub anyway).

If I should be able to make pull requests if I have a contribution, I apologize for assuming otherwise, but also how do I do that?

Willy-JL commented 1 year ago

From the pull requests tab... on GitHub... if vscode tells you that you dont have permission, then thats somethign setup incorrectly with your vscode. What I assume happened is that you cloned the repo as-is and made changes to your local copy. In that case, the "you cont have permission" is because it is trying to push changes directly to my repo. What you do is that you fork the repo, clone that, make changes there, then make a pull request into my repo.

Willy-JL commented 1 year ago

Anyway, this is now fixed via 5e159c8e155b3ad0ce6cabd9b9937e5a3e5264cb and 6c643d1f699cd667fb21d4407e8896bf189ae7ea, thanks for the easy solution @ipaqi. Release is incoming

Willy-JL commented 1 year ago

Fixed in 10.1.2