WillySeahh / duke

Edith Code
https://willyseahh.github.io/duke/
0 stars 0 forks source link

Feedback on week 5 project progress for willyseahh #4

Open nus-se-bot opened 4 years ago

nus-se-bot commented 4 years ago

Leftovers from the previous week

Progress of this week

WillySeahh commented 4 years ago

Professor sorry may I ask are we suppose to create 2 new PRs? But if i work on master for A-Assertions and Code Quality, when i push my original PR from week3 will automatically update.

Also I do not think my master branch can make more than 1 PR, in order to do that I'll have to create another branch and use that branch to PR. But the instructions did not mention about working in another branch.

okkhoy commented 4 years ago

In this case, the PR should be created from a different branch to your own master not to the semester fork of duke. Something similar to last week's task

WillySeahh commented 4 years ago

Prof but the instructions didnt mention that we should create a separate branch and we did not want to not do anything the instructions didn't say.