WillyXJ / facileManager

A modular suite of web apps built with the sysadmin in mind.
www.facilemanager.com
GNU General Public License v2.0
87 stars 37 forks source link

[ISSUE] RateLimit options not being written to named.conf.options #542

Closed oiLvAcciNe closed 2 years ago

oiLvAcciNe commented 2 years ago

Please prefix your issue title with one of the following: [BUG], [ISSUE], [FEATURE REQUEST], [MODULE REQUEST], [OTHER].

Replace everything between stars with current version of your facileManager and module installations:
fM Version : 4.1.2 fmDNS Version : 5.1.1

In raising this issue, I confirm the following (please check boxes, eg [X]):


(BUG | ISSUE) Expected Behavior: Ratelimit options set via web and in sql db should be written to named.conf.options.

(BUG | ISSUE) Actual Behavior: The dns ratelimit options are not visible or sent to named.conf.options during BuildConfig.

{replace this line with your issue content}

As you can see Conf is visible on web/DB .. but not sent to conf files- fmDNSratelimit

oiLvAcciNe commented 2 years ago

[AROUND ISSUE]

IN fm-modules/fmDNS/classes/class_buildconf.php

line 1961

    "$ratelimits .= $this->formatConfigOption($cfg_name, $cfg_info, $cfg_comment);"
    #### should include "$this->server_info"
    $ratelimits .= $this->formatConfigOption($cfg_name, $cfg_info, $cfg_comment, $this->server_info);
    #### because ratelimit option definition require a minimum bind version

in line 2027 "function formatConfigOption"

if ($server_info) {
###it requires this in order to build config array with $cfg_info

Probably there is other modules or options were this is required. For now have found this

WillyXJ commented 2 years ago

This is now fixed in fmDNS 5.2.0 and later.